⭐️ Add Purl to macOS and Windows systems #4996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4957 Signed-off-by: Salim Afiune Maya <[email protected]>
tas50
changed the title
czunker
approved these changes
Dec 16, 2024
| } | ||
| } | ||
|
|
||
| func ValidType(t string) bool { |
There was a problem hiding this comment.
I don't see this being used. Did I miss something?
There was a problem hiding this comment.
When we use this somewhere else, could we add some tests to it?
Some types we use and some we do no longer want to use like windows_app, windows-app.
Signed-off-by: Salim Afiune Maya <[email protected]>
czunker
approved these changes
Dec 17, 2024
| @@ -18,6 +18,23 @@ const ( | |||
| QualifierEpoch = "epoch" | |||
| ) | |||
|
|
|||
| // PackageURL is a helper struct that renters a package url based of an inventory | |||
There was a problem hiding this comment.
renders instead of renters
| // | ||
| // For more information, see: | ||
| // https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst | ||
| func NewPackageURL(pf *inventory.Platform, t Type, name, version string, modifiers ...Modifier) *PackageURL { |
There was a problem hiding this comment.
That made me stumble.
First thought was, that we could derive the type from the platform. But no:
- Windows: windows, appx, nuget, ...
- Ubuntu: deb, snap, brew, ...
- ...
🫤
There was a problem hiding this comment.
yeah, we really can't 😭
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4957
Refactored the
purlpackage.Basic usage.
No platform information.
Will produce the purl:
pkg:deb/[email protected]Main usage. (with platform info)
We rely on the
inventory.Platformthat already has information like the architecturethat can't change. Also we guess the linux distribution from here.
Will produce the purl:
pkg:deb/debian/[email protected]?arch=x86_64&distro=jessieExtended usage. (with modifiers)
We can override optional attributes, like the architecture, epoch and namespace.
This is useful for non-linux systems.
Will produce the purl:
pkg:appx/windows/[email protected]?arch=x86