✨ device: linux lvm support #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results3 163 tests 3 162 ✅ 1m 26s ⏱️ Results for commit cc236c0. ♻️ This comment has been updated with latest results. |
slntopp
force-pushed
the
mik/linux-mount-lvm
branch
from
effab67 to
78ab83c
Compare
|
@slntopp can you add some words about how to best test this new functionality? |
Difference is that before if root partition was |
preslavgerchev
approved these changes
Dec 20, 2024
| func mapLVM2Partitions(part BlockDevice) (partitions []*PartitionInfo) { | ||
| for _, p := range part.Children { | ||
| devFsName := "/dev/mapper/" + p.Name | ||
| partitions = append(partitions, &PartitionInfo{ |
There was a problem hiding this comment.
nit: can we make a blockdevice -> partitioninfo func? i think we use this in more places than here
There was a problem hiding this comment.
added a method to BlockDevice
preslavgerchev
approved these changes
Dec 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed
After mount targets (partitions) are discovered, we'd attempt to either find
fstabfile or detectostreepartition.fstabIf
fstabconfiguration is discovered, provider will parse it and mount all discovered partitions using "opts" configured in the file. This ensures all required features and flags are used, for instance if partition hasbtrfsorxfssub-volumes.Additionally, device manager would add same partition twice or more if it's mounted multiple times with different opts.
Additionally, device manager will attempt to mount these partitions as
/tmp/cnspec-scanxxxx+<fstab mountpoint>By the time we get to attempt detect asset, partitions are already mounted and the scan dir has the structure closest to that in the original VM.
ostreeostreefilesystem together with edge case distros like Fedora CoreOS have a very different file structure as well as missing lot of usual service files (likehostname,machine-id, etc)First of all, device manager attempts to
untanglethe pointers and locate the actual and latest root filesystem.Additionally this PR introduces
bindoption to the volume mounter, which doesn't mount partition again with--bindas one may think, though but adjusts the fs-connection used for asset detection and can be used anywhere else, where the files search relies on standard linux tree structure. For malware detection and similar operationsBindcan be ignored to get the full overview of the system.moby/mount instead of sys/unix
Since
fstaboptions include both flags and "data" we need a reliable way to split those, so mount doesn't crash out withinvalid argumenterror. moby mount provides that, so we simply don't have to reinvent a bicycle here.inject platform ids fallback
As mentioned, some distros don't have usual means of ID-ing the OS like hostname, machine-id or ssh-host-keys. We can however inject custom platform-ids in this cases. With this PR we don't error out from asset detection if no platform ids were found and there are injected ones.