🐛 Fix regex for matching RPM packages with unorthodox vendor name #4726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4714
SuSE's vendor name changed for some reason from
SUSE LLC
toSUSE LLC <https://www.suse.com/>
which no longer matched the regex pattern.In this PR:
/
,:
,<
and>
as allowed characters in the vendor regex pattern.<...>
. That way, we are agnostic as to what the contents of this tag are and we do not hardcode some arbitrary string which may change in the future. This assumes that angle brackets are not used in some other way in the vendor name which I think is a fair assumption given that this is an edge case.Manually tested this on a VM running SuSE 15.6 and
![image](https://private-user-images.githubusercontent.com/50580913/374549093-d6c86385-0fd7-4c1a-9369-437950dd0373.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTk4OTcsIm5iZiI6MTczOTM1OTU5NywicGF0aCI6Ii81MDU4MDkxMy8zNzQ1NDkwOTMtZDZjODYzODUtMGZkNy00YzFhLTkzNjktNDM3OTUwZGQwMzczLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDExMjYzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI0Mjc2ZDc4MjAyMWYxYmIyNWRjMzFlNWEwMmUxOTgxZTQxMGJiYTYxMTVhNjI3NjJjMjkwYjllZmEwOWI0MzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CWhG02HACnhh-lzww8d4cusT7eAwxCVCPpFemKXNybY)
packages.list
produces a correct output:@chris-rock Let me know in case any of my assumptions are invalid and you'd like to handle this differently.