⭐️ Adding support to fetch merge methods (Gitlab) #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HRouhani
commented
Jul 19, 2024
•
HRouhani
commented
HRouhani
changed the title
vjeffrey
approved these changes
Jul 19, 2024
vjeffrey
reviewed
Jul 19, 2024
providers/gitlab/resources/gitlab.lr
Outdated
| } | ||
|
|
||
| // GitLab project merge method | ||
| gitlab.project.mergeMethod @defaults("method") { |
There was a problem hiding this comment.
are you expecting to have more fields in this resource in the future?
if not, mergeMethod() could just become a string
There was a problem hiding this comment.
You are right, it is better keet it simple. done. Thanks
HRouhani
force-pushed
the
hossein/gitlab-merge-check
branch
from
3c26fb5 to
34cacbf
Compare
Signed-off-by: Hossein Rouhani <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
HRouhani
force-pushed
the
hossein/gitlab-merge-check
branch
from
34cacbf to
c884d65
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.