⭐️ Adding the resources for approval settings (Gitlab) #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
vjeffrey
reviewed
Jul 19, 2024
providers/gitlab/resources/gitlab.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| return []interface{}{mqlApprovalSettings}, nil |
There was a problem hiding this comment.
it looks like maybe approval settings should be singular? as in approvalSettings() []gitlab.project.approvalSettings could be approvalSettings() gitlab.project.approvalSettings, since there's only ever one?
if that's true, I think you can change this return to mqlApprovalSettings.(*mqlGitlabProjectApprovalSettings) and then set the return of the function to *mqlGitlabProjectApprovalSettings after changing []gitlab.project.approvalSettings to gitlab.project.approvalSettings
There was a problem hiding this comment.
Thanks, that's true, there is only one approval settings for the whole project. Changed it as requested.
Signed-off-by: Hossein Rouhani <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
HRouhani
force-pushed
the
hossein/gitlab-approvalSettings-1
branch
from
d70c17b to
8b48eec
Compare
vjeffrey
approved these changes
Jul 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important:
we need to figure out why I need to run several time gitlab.project {*} until it works.
Maybe something with initialization which I tried to use and still did not work