🧹 Allow re-running the goreleaser job #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czunker
force-pushed
the
czunker/allow_override
branch
from
656dd08 to
231a909
Compare
imilchev
reviewed
Jun 5, 2024
.goreleaser.yml
Outdated
| @@ -340,3 +340,6 @@ docker_manifests: # https://goreleaser.com/customization/docker_manifest/ | |||
| - mondoo/{{ .ProjectName }}:latest-arm64v8-rootless | |||
| - mondoo/{{ .ProjectName }}:latest-armv6-rootless | |||
| - mondoo/{{ .ProjectName }}:latest-armv7-rootless | |||
| release: | |||
| replace_existing_artifacts: true | |||
| mode: keep-existing | |||
There was a problem hiding this comment.
do we need this when we are replacing existing artifgacts?
There was a problem hiding this comment.
Yes. It is only about the release notes, not the artifacts:
What to do with the release notes in case there the release already exists.
Valid options are:
-
keep-existing: keep the existing notes-
append: append the current release notes to the existing notes-
prepend: prepend the current release notes to the existing notes-
replace: replace existing notesDefault is
keep-existing.mode: append
https://goreleaser.com/customization/release/?h=replace_existing_artifacts#github
Perhaps not, now that I see the default.
With this change, it can override the existing release files. This can help in case something goes wrong. Signed-off-by: Christian Zunker <[email protected]>
czunker
force-pushed
the
czunker/allow_override
branch
from
231a909 to
c224a0f
Compare
imilchev
approved these changes
Jun 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it can override the existing release files. This can help in case something goes wrong.