Fix log metrics bug 491 #492
Conversation
There was a problem hiding this comment.
Thank you for this fix, looks fine.
I have one request: add info about LOG_LEVEL to README in configuration section:
https://github.com/monasca/monasca-docker/tree/master/monasca-log-metrics#configuration
|
ok |
There was a problem hiding this comment.
You also need to update file build.yml https://github.com/monasca/monasca-docker/blob/master/monasca-log-metrics/build.yml#L3
Change:
- tag: 0.0.1
to
- tag: 0.1.0
monasca-log-metrics/Dockerfile
Outdated
| @@ -8,6 +8,7 @@ ENV CONFIG_TEMPLATE=true \ | |||
| KAFKA_URI=kafka:9092 \ | |||
| ZOOKEEPER_URI=zookeeper:2181 \ | |||
| KAFKA_WAIT_FOR_TOPICS=log-transformed,metrics | |||
There was a problem hiding this comment.
Missing \ at the end. Without it Dockerfile is not working
monasca-log-metrics/README.md
Outdated
| @@ -21,6 +21,7 @@ Configuration | |||
| | `KAFKA_WAIT_FOR_TOPICS` | `log-transformed,metrics` | Topics to wait on at startup | | |||
| | `KAFKA_WAIT_RETRIES` | `24` | # of kafka wait attempts | | |||
| | `KAFKA_WAIT_DELAY` | `5` | # seconds to wait between attempts | | |||
| | `LOG_LEVEL` | `warning,error,fatal` | Metric name need to transformed be from log | | |||
There was a problem hiding this comment.
Change description to: List all log levels converted to metrics
| @@ -24,7 +24,7 @@ filter { | |||
| } | |||
|
|
|||
| # drop logs with log level not in warning,error | |||
There was a problem hiding this comment.
Replace warning,error with LOG_LEVEL
There was a problem hiding this comment.
ok,very thanks
standard log level has seven types including:AUDIT,CRITICAL,DEBUG,INFO,TRACE,ERR,WARN.but monasca log metrics component only support warning and error types to transform to metrics(log.warn log.error).and user can not config that types.it is not a rational disign.