Add Github workflow to run tests #1372
Open
+57
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrfennell
changed the title
matthewrfennell
force-pushed
the
prepare-to-run-tests-in-build
branch
from
60beff7 to
40e1629
Compare
XCTest prepends the product name to the name of the .xctest file. For instance - if the target's product name is xyz, the xctest file would be named xyz.xctest. Since we have multiple test targets in the project, the lack of a product name caused two xctest files to be generated with the same name, and copied to the same build location. This caused build errors when trying to run the test targets. Therefore - ensure there is a product name provided for each test target, so that we can build and run the tests.
Traditionally in Monal, tests have not been automatically run against PRs. We are thinking of changing this and running tests against certain PRs. As a result, we want to skip tests that always fail. It so happens that these are all UI tests. As a result: delete most UI tests. They can always be re-written later. Leave one example of a test for future reference.
matthewrfennell
force-pushed
the
prepare-to-run-tests-in-build
branch
from
40e1629 to
4488721
Compare
|
It would be great if the name, result and duration of our test could be extracted from this huge blob of xcodebuild output and printed in a separate workflow step. Maybe even with unicode checkmarks or crossmarks in front. If you want some examples how to forward data between build steps, you could check out our stable build script and the changelog extraction in there. No merge blocker, though :) |
matthewrfennell
force-pushed
the
prepare-to-run-tests-in-build
branch
2 times, most recently
from
e5ac92c to
cd2b095
Compare
matthewrfennell
force-pushed
the
prepare-to-run-tests-in-build
branch
from
cd2b095 to
101976a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an example run:
https://github.com/matthewrfennell/Monal/actions/runs/12838210714/job/35803392375
Next steps after this (in future PRs?)
xcbeautifyon all build workflows