feat(notification-system): add screen reader announcer #745
Conversation
| notificationSystemId?: string; | ||
| notificationSystemId: string; | ||
| /** | ||
| * Screen reader announcement to be made |
There was a problem hiding this comment.
Add "no announcement is made if left blank"
| @@ -20,7 +20,11 @@ type CustomOptions = { | |||
| * | |||
| * Can be used to trigger multiple notifications at different positions on the screen at the same time | |||
There was a problem hiding this comment.
Add "also used to find which ScreenReader identity to send the SR Announcement to, in case screenReaderAnnouncement is defined"
There was a problem hiding this comment.
i'm not sure this is needed, users of this component don't need to know the inner workings of the SR part
| aria-label={ariaLabel} | ||
| > | ||
| <ToastContainer | ||
| {...commonProps} |
There was a problem hiding this comment.
I see this react-toastify ToastContainer is giving the role="alert" to that wrapper (with empty "" aria-label !). Role="alert" could interfere with our new SRAnnouncement. So let's pass role: "generic" to commonProps so that the DOM gets no role="alert" wrapper.
There was a problem hiding this comment.
(not doing, as discussed)
There was a problem hiding this comment.
Oki, we are doing this later so that non IMC notifications are still announced with role="alert"
There was a problem hiding this comment.
yup, or maybe it won't be needed when you do your PR?
| aria-label={ariaLabel} | ||
| > | ||
| <ToastContainer | ||
| {...commonProps} |
There was a problem hiding this comment.
Oki, we are doing this later so that non IMC notifications are still announced with role="alert"
|
🎉 This PR is included in version 26.192.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
IMPORTANT
Currently, this project is closed to any external contributions. Any pull request made against this project from external sources will likely be closed. If you would like to make changes to this project, please fork this project.
Guide
This "Help" section can be deleted before submitting this pull request.
Update the name of this pull request to reflect the following shape:
Provide a general summary of the scope of the changes in this pull request.
Description
Links
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-598178