Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextInput): add warning if aria label and label are same #730

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feat(TextInput): add warning if aria label and label are same #730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/TextInput/TextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ const TextInput = (props: Props, ref: RefObject<HTMLInputElement>): ReactElement
inputMaxLen,
} = props;

const ariaLabel = props['aria-label'];

if (ariaLabel && label && ariaLabel === label) {
console.warn(
`MRV2: The aria-label and visible label of the Text Input are the same, making SR read it twice. Please provide only 1. Aria-label: ${ariaLabel}. Visible label: ${label}`
);
}

const componentRef = React.useRef<HTMLInputElement>();
const inputRef = ref || componentRef;

Expand Down
Loading