feat(a11y): make tagName mandatory in Text and add it where necessary #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lismith2-cisco
force-pushed
the
SPARK-582909-mandatory-text-tagname
branch
2 times, most recently
from
e37aa86 to
5b320d7
Compare
nataliadelmar
approved these changes
Nov 28, 2024
|
Let's first have a Cantina PR ready before we merge this otherwise it would block MRV2 bump |
nataliadelmar
approved these changes
Dec 4, 2024
lismith2-cisco
force-pushed
the
SPARK-582909-mandatory-text-tagname
branch
from
6bc5b00 to
39f6250
Compare
lismith2-cisco
force-pushed
the
SPARK-582909-mandatory-text-tagname
branch
from
39f6250 to
a317a99
Compare
|
🎉 This PR is included in version 26.184.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make tagName mandatory in Text and add it where necessary. This is to ensure tag reflects page structure, not stying.
have changes to their interface, all other changes are trivial (although this touches a lot of files)
Links
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-582909