Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add workflow and package json changes to publush to npmrc #3

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

pratik151192
Copy link
Collaborator

@pratik151192 pratik151192 commented Oct 2, 2023

PR adds logic to be able to publish package to npmjs

@pratik151192 pratik151192 marked this pull request as ready for review October 2, 2023 18:00
@@ -1,7 +1,7 @@
{
"name": "momento-sequelize-cache",
"name": "@gomomento-poc/momento-sequelize-cache",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am assuming this is enough to be published to this namespace.

type: now
from_branch: main
target_branch: release
github_token: ${{ secrets.MOMENTO_MACHINE_USER_GITHUB_TOKEN }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cprice404 : we probably need this secret too and there's another GITHUB_TOKEN in the next file.. not sure if they serve the same purpose and i copy pasted from node-redis but lmk if i should make this the same.

@pratik151192
Copy link
Collaborator Author

@cprice404 once this is out i'd like to change examples to point to the registry instead of local and watch out for any gotchas


on:
push:
branches: [ release ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine for today, let's get it out there, but i just realized... we have been trying to switch things over to use the "release please" plugin, it would be really great to have another example of that. just something to keep in mind if you have time later this week. @pgautier404 is a good contact if you have questions.

@pratik151192 pratik151192 merged commit bb736f2 into main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants