fix: bug for cache misses and count calls #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratik151192
commented
Oct 30, 2023
src/model-cache.ts
Outdated
| if (typeof results === 'number') { | ||
| // like for count() calls | ||
| return results.toString(); | ||
| if (!data) { |
There was a problem hiding this comment.
i am leaving this as is just for now and will address in a follow up PR based on our discussion in #typescript channel. The reason is this was the behavior Jah expected here in his code and here falsyness might mean multiple things so want to make a more careful call here
There was a problem hiding this comment.
Neverr mind fixed it as i see no other case
cprice404
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jah reported a bug where
0was not being compressed:This
0basically comes out ofcount()queries and if there's no data present. This was being interpreted akin toundefinedand never went through thenumbercheck and was not being transformed to a string.Was able to repro through a test that succeeded after bug fix