-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add competition ranking to leaderboard #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple changes upon review:
- An oversight from the previous PR: I should have re-used
FetchResponse
forget_rank
instead of making a new response type. Could you refactorget_competition_rank
to useFetchResponse
instead of a new response type here as well? - Also refactor
get_rank
to use the same
GH Actions seem to checkout older code revisions of this PR.... odd.... |
https://github.com/momentohq/client-sdk-rust/actions/runs/13294066680/job/37121603883?pr=439 It's complaning about:
but that doesn't match the code in this PR: 5d07ce6#diff-fd78100889d055010c44e3f81caf0225a1545b419395f83c7823dfd764eee13fR415
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.