fix: try on: pull_request_target to share secrets with fork instead of on: pull_request #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on: pull_request_target
allows the sharing of secrets with forks, and it should be used with a safeguard, such as checking the permissions of the triggering actor, as we do here.on: pull_request
will not share secrets with forks, even if triggering actor has write permissions, as seen with this PR: #6Also did some minor cleanup of the workflow file:
checkout
action is fine, removed the second block with non-default refif
condition in github actions syntax to avoid printing out the secret when checking if it exists