Adding country functionality from metadata

[adgrace]

PR for adding country functionality from metadata.

API:
var zones = moment.tz.zonesForCountry('US'); // returns ['America/Chicago', ' America/New_York', etc...]
var country = moment.tz.zone('America/Los_Angeles').country; // returns ['US']

Countries has been added to each zone containing the countries within the zone as well as a countries section containing the abbreviation and zones inside to both the packed and unpacked data.

I welcome any feedback and feel free to ask any questions or for further development.

Sorry for the delay adding the feature, I am a student at university and have a high workload at the moment.

Issues requesting the feature:

• Get time zone(s) from abbreviation and country code #289
• Add country to the Zone object #400

Original Pull Request: #377 ** had some difficulty with not being able to merge and so created new pull request, sorry for any inconvenience.

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ mj1856
✅ DanielRuf
✅ adgrace
❌ HNDeploys

[maggiepint]

Something is wrong here. Moment should not be in the source.

[adgrace]

I'm not sure how that happened! Do I need to run "grunt clean"?

On 6 Nov 2016, at 2:49 pm, Maggie Pint [email protected] wrote:

Something is wrong here. Moment should not be in the source.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[mattjohnsonpint]

You've committed way more files than are actually part of the project. Did you maybe modify or delete your .gitignore file?

[marwahaha]

I can jump onto this @alexgrace95 if you're busy right now. It should be a quick fix, or we can chat online about how to fix this.

[mattjohnsonpint]

@alexgrace95 - ping

[adgrace]

Hi @mj1856 & @marwahaha.
Sorry about my ultra slow reply, I have been snowed under with final year university work! I emailed @marwahaha with the email address on his GitHub profile but I am not sure if it is still active as I have had no reply?
I have a little bit of time over christmas and would like to get the pull request finished! @marwahaha please let me know how you think it should be resolved? @mj1856 could this have happened if I had pulled from the Master instead of the Dev?
Thanks,
Alex

[adgrace]

I have removed Moment from the source (I think may have been caused by running "bower install" at some point) and resolved the conflicts.
Thank you @marwahaha very much for all your help!

[mattjohnsonpint]

Please rebase

[marwahaha]

Out of curiosity @mj1856 , what's wrong with a squash and merge? Just trying to understand.

[adgrace]

I have squashed and rebased and resolved the conflicts! :)

[adgrace]

Hi @mj1856 & @maggiepint,
Is this ready to be merged?

[reimertz]

@alexgrace95 thank you soo much for doing this! I have been looking for this dataset for about 3 days and was about to give up and just create it myself. 🙏

[maggiepint]

Can we rebase the built files out of this pull? If so, will merge.

[cmalard]

Hello there, @alexgrace95 do you still have availability to rebase this PR ? :-) Would be much appreciated 🎉

[adgrace]

Hi, yes will try to do it within the week, Happy New Year!

…

On 31 Dec 2017, at 4:04 am, Cédric Malard ***@***.***> wrote: Hello there, @alexgrace95 do you still have availability to rebase this PR ? :-) Would be much appreciated 🎉 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[xicovarisco]

Do you guys have an ETA on when this functionality will be merged?

[adgrace]

Hi All,
I have resolved the conflicts.
@maggiepint or @mj1856 please can you review?
Sorry for the delay, I have been really busy with other exciting projects.

[cmalard]

[NuclearMachine]

This is stupid. A highly sought and needed feature has not been merged in 3 years.

[dtminnaar]

I am also looking for this feature 👍

[ellenaua]

It's going tomorrow to production. Version 0.5.28
I'll do more tests in my morning & release.

[adgrace]

@ellenaua Let me know if you need it rebased or anything. Look forward to it being merged 😊

[ellenaua]

Tadaaam 🥇 🥇
It was too hard to resolve conflicts, I "picked" commits from your branch @adgrace but mentioned you in commit messages so that world knows the author.
https://momentjs.com/timezone/docs/#/using-timezones/getting-country-zones/

[stefanRepac]

Far as i see, there is no solution to do this?
var country = moment.tz.zone('America/Los_Angeles').country; // returns ['US']

[lvillacin]

Same thoughts with @Soullighter canmoment.tz.zone().country be implemented?

[stefanRepac]

@Ivillacin
Check my codepen for solution
https://codepen.io/Soullighter/pen/MWKVvvP
Far as i remember it’s under get_locale variable