Adds first version of the MCT driver

[gustavo-marques]

Summary of commits:

• config_src/mct_driver/ocn_comp_mct.F90 - Adds the main driver for MOM6 in CIME. This module 1) initializes, 2) runs, and 3) finalizes MOM6 via the CESM framework. The model successfully run for one month using CORE forcing. There are mismatches between MCT and MOM6 in terms of ice ocean boundary fluxes that need to be accounted in the future. These have been documented in the code. We have followed MOM6 code style guide and the module has been Doxygenized.

Changes on existent MOM6 modules

• config_src/coupled_driver/ocean_model_MOM.F90 - Adds a subroutine that returns pointers to objects within ocean_state_type;

• src/core/MOM_grid.F90 - Adds a subroutine that returns global shape of horizontal grid;

• src/framework/MOM_domains.F90 - Adds a subroutine that returns the global shape of h-point arrays;

• src/initialization/MOM_coord_initialization.F90 - Fixes gprime(1) when no layer coordinates are set.

• src/initialization/MOM_state_initialization.F90 - Adds option to read initial temp and salt from separate files;

• src/ice_shelf/MOM_ice_shelf.F90 - Removes frazil's contribution to evaporation. Frazil formation was being converted to surface layer evaporation under ice shelves and this was double counting the effect of frazil on the system;

• src/parameterizations/lateral/MOM_hor_visc.F90 - Avoids a SEGV when OBC are not in use with bi-harmonic friction.

[adcroft]

This is a PR from NCAR to dev/master. dev/master is currently using a different version of FMS so testing this PR requires a clean build.

• Answers change (see below);
• MOM_parameter_docs are affected due to some new FROM_Z_INIT parameters.

Commit be46fee is cherry-picked from dev/gfdl and changes the apparent answers due to a change in definition of energy (this commit set gprime to non-zero in ALE mode).

• Affected experiments are logged in the be46fee commit message;
• I have checked that reverting commit be46fee recovers answer on dev/master;
• I have also checked that merging from the candidate dev/master on to dev/gfdl recovers dev/gfdl (which already has commit be46fee ).

In all, this passes tests.

[adcroft]

@kshedstrom Can you that check that this branch works for you (given the caveats in previous comment) and give us the thumbs up or down?

[kshedstrom]

So I have to guess which version of FMS? It's not obvious to me how to know that. Guessing dev/master gives a compile-time error:

-fcray-pointer -fdefault-double-8 -fdefault-real-8 -Waliasing -ffree-line-length-none -fno-range-check -I/u1/uaf/kshedstrom/include -I../../shared/repro -c -I//center1/d/kate/ESMG/ESMG-configs/src/MOM6/src/framework //center1/d/kate/ESMG/ESMG-configs/src/MOM6/src/diagnostics/MOM_debugging.F90
//center1/d/kate/ESMG/ESMG-configs/src/MOM6/src/framework/MOM_io.F90:19:32:

use fms_io_mod, only : get_filename_appendix => get_filename_appendix
1
Error: Symbol ‘get_filename_appendix’ referenced at (1) not found in module ‘fms_io_mod’
//center1/d/kate/ESMG/ESMG-configs/src/MOM6/src/framework/MOM_io.F90:39:93:

public :: close_file, create_file, field_exists, field_size, fieldtype, get_filename_appendix
1
Error: Symbol ‘get_filename_appendix’ at (1) has no IMPLICIT type
make[1]: *** [Makefile:175: MOM_io.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/import/c1/w/kshedstrom/MOM6/build/gnu/symmetric_ocean_only/repro'
make: *** [Makefile:497: /center1/w/kshedstrom/MOM6/build/gnu/symmetric_ocean_only/repro/MOM6] Error 2

[adcroft]

Sorry, I should have specified: 32a7923, as recorded in src/ of dev/master at https://github.com/NOAA-GFDL/MOM6-examples/tree/dev/master/src.

…

-- Dr Alistair Adcroft ([email protected]) Princeton University Tel: (609) 987-5073 NOAA/GFDL, 201 Forrestal Road, Princeton, NJ 08540

On Thu, Aug 17, 2017 at 3:09 PM, Kate Hedstrom ***@***.***> wrote: So I have to guess which version of FMS? It's not obvious to me how to know that. Guessing dev/master gives a compile-time error: -fcray-pointer -fdefault-double-8 -fdefault-real-8 -Waliasing -ffree-line-length-none -fno-range-check -I/u1/uaf/kshedstrom/include -I../../shared/repro -c -I//center1/d/kate/ESMG/ESMG-configs/src/MOM6/src/framework //center1/d/kate/ESMG/ESMG-configs/src/MOM6/src/ diagnostics/MOM_debugging.F90 //center1/d/kate/ESMG/ESMG-configs/src/MOM6/src/ framework/MOM_io.F90:19:32: use fms_io_mod, only : get_filename_appendix => get_filename_appendix 1 Error: Symbol ‘get_filename_appendix’ referenced at (1) not found in module ‘fms_io_mod’ //center1/d/kate/ESMG/ESMG-configs/src/MOM6/src/ framework/MOM_io.F90:39:93: public :: close_file, create_file, field_exists, field_size, fieldtype, get_filename_appendix 1 Error: Symbol ‘get_filename_appendix’ at (1) has no IMPLICIT type make[1]: *** [Makefile:175: MOM_io.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory '/import/c1/w/kshedstrom/MOM6/ build/gnu/symmetric_ocean_only/repro' make: *** [Makefile:497: /center1/w/kshedstrom/MOM6/ build/gnu/symmetric_ocean_only/repro/MOM6] Error 2 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <NOAA-GFDL#578 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFlo8-I97mXCgAkPs0em7RvUQ2vg2Ji0ks5sZI_agaJpZM4O5Yr7> .

[kshedstrom]

Thanks. Yes, all my little ocean-only tests run, with small answer changes I would expect. CCS is in the queue.