189 h to m #196
Merged
189 h to m #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I've made the changes suggested by @Hallberg-NOAA, it should |
|
Typo? "not" or "now"? |
|
Yes, a typo |
- show ranks when doing vector multiplies, - replace G%Angstrom_z with G%Angstrom in various places, - fix units of eta_bt, - improve comments
arbitrary H units - no need to convert to m before calling it. mom-ocean#189
|
@adcroft I have made the changes we talked about: i.e. moving the H <-> m conversion into the ALE grid generation. This means that there's no need to switch H_to_m before calling ALE_main(). It should now be ready to merge. |
MJHarrison-GFDL
pushed a commit
to MJHarrison-GFDL/MOM6
that referenced
this pull request
Aug 16, 2022
__APPLE__ replaced with autoconf test for gettid
marshallward
pushed a commit
to Hallberg-NOAA/MOM6
that referenced
this pull request
Sep 8, 2022
Disable sigsetjmp for default compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.