Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up pass_var for tracer reservoirs. #1205

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Clean up pass_var for tracer reservoirs. #1205

merged 1 commit into from
Sep 11, 2020

Conversation

kshedstrom
Copy link
Collaborator

Use new options to pass_var, saves having to allocate both directions of tracer reservoirs if only one is used.

@codecov-commenter
Copy link

Codecov Report

Merging #1205 into dev/gfdl will decrease coverage by 0.01%.
The diff coverage is 37.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1205      +/-   ##
============================================
- Coverage     46.08%   46.06%   -0.02%     
============================================
  Files           214      224      +10     
  Lines         69399    70581    +1182     
============================================
+ Hits          31984    32516     +532     
- Misses        37415    38065     +650     
Impacted Files Coverage Δ
...g_src/external/GFDL_ocean_BGC/FMS_coupler_util.F90 0.00% <0.00%> (ø)
...fig_src/external/GFDL_ocean_BGC/generic_tracer.F90 0.00% <0.00%> (ø)
...c/external/GFDL_ocean_BGC/generic_tracer_utils.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/kdtree.f90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_core.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_types.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/write_ocean_obs.F90 0.00% <0.00%> (ø)
config_src/solo_driver/MESO_surface_forcing.F90 0.00% <0.00%> (ø)
config_src/solo_driver/user_surface_forcing.F90 0.00% <0.00%> (ø)
src/ALE/MOM_regridding.F90 31.47% <0.00%> (-0.17%) ⬇️
... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e40bf9...3ce4172. Read the comment docs.

@Hallberg-NOAA
Copy link
Collaborator

This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11164.

Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are correctly exploiting recently added capabilities to reduce the need for excessive memory allocations and message passing.

This commit pull request should be acted upon as soon as the pipeline tests have passed.

@Hallberg-NOAA Hallberg-NOAA merged commit 9724e7f into mom-ocean:dev/gfdl Sep 11, 2020
@kshedstrom kshedstrom deleted the obc_pass_var branch September 15, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants