Brankart PGF update #1193
Merged
Brankart PGF update #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adcroft
commented
Aug 31, 2020
adcroft
commented
- Adds a diagnostic of the parameterized SGS temperature variance
- Updates the estimate of grid-scale variance, replacing a gradient-along-coordinate squared form by a thickness-weighted least-squares fit. The latter handles coordinates collapsed against topography much better and addresses the spurious behavior we were seeing.
- Adds a diagnostic of the parameterized SGS T variance used in the Brankart correction to the PGF
- The SGS T variance is measure from the grid-scale variance. It should be a horizontal difference but is approximated as along coordinate. This adds thickness weighting to avoid large values near topography.
- One line was too long - Noticed several spelling and grammar problems in comments
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1193 +/- ##
============================================
- Coverage 46.08% 46.03% -0.05%
============================================
Files 214 224 +10
Lines 69399 70537 +1138
============================================
+ Hits 31984 32474 +490
- Misses 37415 38063 +648
Continue to review full report at Codecov.
|
|
Closing to solve a restart problem that appeared with the merge |
- The restart tests were failing because land values differ before/after a restart. Adding 2d land masking of h value in the stencil removes the sensitivity.
- A variable was poorly named and also changed units mid-stream. The newly named variable now only has the same units ever.
|
This PR changes answers in some test cases (e.g., TC2 in .testing), although it does not change any answers in the MOM6-examples test suite. This should have been noted in the comments describing this PR. |
Hallberg-NOAA
approved these changes
Sep 8, 2020
|
Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11144 ✔️ |
This was referenced Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.