Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+Allow position=NORTH_FACE in pass_var calls #1188

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

Hallberg-NOAA
Copy link
Collaborator

Added code to handle the cases where the position argument to pass_var
is set to NORTH_FACE or EAST_FACE. All answers are bitwise identical.

  Added code to handle the cases where the position argument to pass_var
is set to NORTH_FACE or EAST_FACE.  All answers are bitwise identical.
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #1188 into dev/gfdl will decrease coverage by 0.06%.
The diff coverage is 37.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1188      +/-   ##
============================================
- Coverage     46.08%   46.01%   -0.07%     
============================================
  Files           214      224      +10     
  Lines         69399    70501    +1102     
============================================
+ Hits          31984    32443     +459     
- Misses        37415    38058     +643     
Impacted Files Coverage Δ
...g_src/external/GFDL_ocean_BGC/FMS_coupler_util.F90 0.00% <0.00%> (ø)
...fig_src/external/GFDL_ocean_BGC/generic_tracer.F90 0.00% <0.00%> (ø)
...c/external/GFDL_ocean_BGC/generic_tracer_utils.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/kdtree.f90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_core.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_types.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/write_ocean_obs.F90 0.00% <0.00%> (ø)
config_src/solo_driver/MESO_surface_forcing.F90 0.00% <0.00%> (ø)
config_src/solo_driver/MOM_driver.F90 68.72% <ø> (ø)
config_src/solo_driver/user_surface_forcing.F90 0.00% <0.00%> (ø)
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4205f6...78335a1. Read the comment docs.

Copy link
Collaborator

@adcroft adcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adcroft adcroft merged commit 457ca3d into mom-ocean:dev/gfdl Sep 1, 2020
@Hallberg-NOAA Hallberg-NOAA deleted the pass_var_opts branch July 30, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants