Fixing loop bound error in MOM_PressureForce_Montgomery.F90 #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "for" loop at L510 should be to nz instead of nz+1. Due to array allocation sizes, this loop was extending beyond the shope of the argument arrays.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1169 +/- ##
============================================
- Coverage 46.08% 45.81% -0.28%
============================================
Files 214 224 +10
Lines 69399 70244 +845
============================================
+ Hits 31984 32179 +195
- Misses 37415 38065 +650
Continue to review full report at Codecov.
|
marshallward
approved these changes
Jul 27, 2020
|
Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10884 Test has passed; no regressions. |
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "for" loop at L510 should be to nz instead of nz+1. Due to array allocation sizes, this loop was extending beyond the shape of the argument arrays.
I checked a couple of ocean_only test cases (e.g., global_ALE, but I'm not 100% sure it uses this part of the code) and this did not change answers. But that could be sensitive to which compiler is used, etc.