MOM6: (*?)Revised ice_shelf_driver.F90 so it compiles #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised ice_shelf_driver.F90 so that it compiles successfully and is similar to MOM_driver.F90 where possible. In addition, deleted the files MOM_surface_forcing.F90 and user_surface_forcing.F90 in the ice_solo_driver directory, as these are unused and out-of-date versions of the equivalent files in the solo_driver directory. Some of the changes are not as streamlines as they could be if the solo_ice_shelf code used its own version of diag_mediator, or if the interface to diag_mediator were revised so that some of its ocean-specific arguments are optional. There is no test-case exercising this code, but at least it now compiles, whereas it did not compile before.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1162 +/- ##
============================================
- Coverage 46.08% 45.85% -0.24%
============================================
Files 214 224 +10
Lines 69399 70082 +683
============================================
+ Hits 31984 32137 +153
- Misses 37415 37945 +530
Continue to review full report at Codecov.
|
adcroft
approved these changes
Jul 23, 2020
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised ice_shelf_driver.F90 so that it compiles successfully and is similar
to MOM_driver.F90 where possible. In addition, deleted the files
MOM_surface_forcing.F90 and user_surface_forcing.F90 in the ice_solo_driver
directory, as these are unused and out-of-date versions of the equivalent files
in the solo_driver directory. Some of the changes are not as streamlines as
they could be if the solo_ice_shelf code used its own version of diag_mediator,
or if the interface to diag_mediator were revised so that some of its
ocean-specific arguments are optional. There is no test-case exercising this
code, but at least it now compiles, whereas it did not compile before.