Testing: Removed environment flag checks #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to unpredictable conflicts with flags, the realization that flag testing would launch jobs on Slurm environment, and the fact that Slurm launchers, OpenMPI, and MPICH all appear to pass environment variables on default, we now just assume that "env=val $(MPIRUN)" will pass an environment variable to the MPI job in all cases. This may not be true on all systems, but for now we will assume this works.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1144 +/- ##
============================================
- Coverage 46.08% 45.78% -0.31%
============================================
Files 214 223 +9
Lines 69399 69835 +436
============================================
- Hits 31984 31972 -12
- Misses 37415 37863 +448
Continue to review full report at Codecov.
|
adcroft
approved these changes
Jun 26, 2020
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to unpredictable conflicts with flags, the realization that flag
testing would launch jobs on Slurm environment, and the fact that Slurm
launchers, OpenMPI, and MPICH all appear to pass environment variables
on default, we now just assume that "env=val $(MPIRUN)" will pass an
environment variable to the MPI job in all cases.
This may not be true on all systems, but for now we will assume this
works.