Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics registered but not posted (conSST, absSSS, abssalt, contemp) #574

Closed
nichannah opened this issue Aug 14, 2017 · 1 comment
Closed

Diagnostics registered but not posted (conSST, absSSS, abssalt, contemp) #574

nichannah opened this issue Aug 14, 2017 · 1 comment

Comments

@nichannah
Copy link
Collaborator

These diagnostics are registered if CS%use_temperature = .true. however will only be posted if CS%use_conT_absS = .true.

One reason we need diagnostics to be registered and posted under the same conditions is that it allows users to identify which diagnostics are available for a given configuration.

This problem was revealed by the MOM diagnostics test: https://accessdev.nci.org.au/jenkins/job/mom-ocean.org/
(Understandably it's relevance has been diminished recently because it hasn't had a 'pass' status in a long time!)
@nichannah nichannah changed the title Diagnostics registered but not posted (conSST and absSSS) Diagnostics registered but not posted (conSST, absSSS, abssalt, contemp) Aug 14, 2017
nichannah pushed a commit to nichannah/MOM6 that referenced this issue Aug 14, 2017
Don't register diagnostics conSST absSSS, abssalt, contemp unless
6ada607 
they can be posted. mom-ocean#574
nichannah pushed a commit to nichannah/MOM6 that referenced this issue Aug 14, 2017
Don't register h_pre_dyn, it is never posted. mom-ocean#574
9183c22
@nichannah nichannah mentioned this issue Aug 14, 2017
Closed
@Hallberg-NOAA
Copy link
Collaborator

This issue was addressed on August 15, 2017 by PR #575.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nichannah @Hallberg-NOAA