Transform test failing set_viscous_ML, calculation of uhtot looks wrong. #516
Comments
Hallberg-NOAA
pushed a commit
to Hallberg-NOAA/MOM6
that referenced
this issue
Nov 10, 2023
- Added simple single-thread program to invoke EOS_unit_tests.F90
- Added not-as-simple program to time the cost of calculate_density()
and calculate_spec_vol() for both scalar and array APIs
- Placed in new directory config_src/drivers/timing_tests/
- Renamed MOM_unit_test_driver.F90 to test_MOM_file_parser.F90
- Updated .testing/Makefile
- Added list of programs in config_src/drivers/unit_tests
- These are added to BUILDS if DO_UNIT_TESTS is not blank.
(DO_UNIT_TESTS was an existing macro but it might be uneeded)
- These programs are compiled with code coverage
- Added list of programs in config_src/drivers/timing_tests
- These programs are compiled with optimization and no coverage
- Fixed rule for building UNIT_EXECS (which did not re-build properly
because the central Makefile was trying to model the dependencies
even though those dependencies are in the build/unit/Makefile.dep)
- Added convenient targets build.unit, run.unit, build.timing, run.timing
- Timing tests currently time a loop over 1000 calls (so that the resolution
of the CPU timer is not too large) and 400 samples to collect statistics
on timings. On gaea c5 this takes about 10 seconds.
- The results are written to stdout in json.
- Added placeholder build and run of timing_tests to GH workflow.
- Enabled for [push,pull_request]
- We probably will not be able to use timings from GH but I still want
to exercise the code we know the timing programs aren't broken by a
commit.
- Also added driver for string_functions_unit_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At src/parameterizations/vertical/MOM_set_viscosity.F90:1473 uhtot() is being calculated at v points using an average of wind stresses from neighbouring points. This calculation is erroneously using j-directed wind stresses (fluxes%tauy) in the calculation.
Pull request to follow.
The text was updated successfully, but these errors were encountered: