Failure to compile with PGI

[kshedstrom]

I'm getting this problem with PGI on our systems:

mpif90 -Duse_libMPI -Duse_netCDF -DSPMD -Duse_LARGEFILE   -Kieee -I/usr/mpi/gcc/openmpi-1.8.5/include -I/usr/include -I/usr/local/pkg/netcdf/netcdf-4.3.0.pgi-13.4/include -DPGI -O0 -g -C   -c -I/center/d/kate/ESMG/ESMG-configs/src/FMS/include -I/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include   /center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/mpp.F90
PGF90-S-0155-Could not resolve generic procedure mpp_min (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 220)
PGF90-S-0155-Could not resolve generic procedure mpp_max (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 221)
PGF90-S-0155-Could not resolve generic procedure mpp_sum (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 222)
PGF90-S-0155-Could not resolve generic procedure mpp_sum (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 223)
PGF90-S-0155-Could not resolve generic procedure mpp_min (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 247)
PGF90-S-0155-Could not resolve generic procedure mpp_max (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 248)
PGF90-S-0155-Could not resolve generic procedure mpp_sum (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 249)
PGF90-S-0155-Could not resolve generic procedure mpp_sum (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 250)
PGF90-S-0155-Could not resolve generic procedure mpp_min (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 253)
PGF90-S-0155-Could not resolve generic procedure mpp_max (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 254)
PGF90-S-0155-Could not resolve generic procedure mpp_sum (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 255)

It's true for other versions as well:

mpif90 -Duse_libMPI -Duse_netCDF -DSPMD -Duse_LARGEFILE   -Kieee -I/usr/mpi/gcc/openmpi-1.8.5/include -I/usr/include -I/usr/local/pkg/netcdf/netcdf-4.3.0.pgi-12.10/include -DPGI -O0 -g -C   -c -I/center/d/kate/ESMG/ESMG-configs/src/FMS/include -I/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include  /center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/mpp.F90
PGF90-S-0155-Could not resolve generic procedure mpp_min (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 220)
PGF90-S-0155-Could not resolve generic procedure mpp_max (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 221)

mpif90 -Duse_libMPI -Duse_netCDF -DSPMD -Duse_LARGEFILE   -Kieee -I/usr/mpi/gcc/openmpi-1.8.5/include -I/usr/include -I/usr/local/pkg/netcdf/netcdf-4.3.3.1.pgi-15.7/include -DPGI -O0 -g -C   -c -I/center/d/kate/ESMG/ESMG-configs/src/FMS/include -I/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include /center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/mpp.F90
PGF90-W-0951-Extraneous tokens ignored following # directive (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_util.inc: 1440)
PGF90-S-0155-Could not resolve generic procedure mpp_min (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 220)
PGF90-S-0155-Could not resolve generic procedure mpp_max (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 221)
PGF90-S-0155-Could not resolve generic procedure mpp_sum (/center/d/kate/ESMG/ESMG-configs/src/FMS/mpp/include/mpp_comm_mpi.inc: 222)

[adcroft]

Adding '-i4 -r8' to FFLAGS in the mkmf template solved this issue.

I'm not sure whether it is correct that we need those compiler options in order to compile. One would expect that code would compile with no casting to double precision etc.

@MJHarrison-GFDL gets credit for figuring this one out.