Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs are fixed in 2 files: #249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xiaobin1124
Copy link

1, fms_io.F90, kind=8 allow very large file size definitions.
2, fixed bugs in fregrid.c for vector regriding functionality.

    1, fms_io.F90, kind=8 allow very large file size definitions.
    2, fixed bugs in fregrid.c for vector regriding functionality.
Copy link
Collaborator

@russfiedler russfiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I would change the declaration in fms_io.F90 to

integer(LONG_KIND) :: var_sz, size_in_file ! The size in bytes of each variable and of the variables already in a file.

for consistency (and portability).

@marshallward
Copy link
Collaborator

Hi @xiaobin1124, sorry for the long delay in replying to this. We've started to discuss how to improve governance of the code and how to keep track of these contributions.

The shared and tools directories are copies of the FMS and FRE tool repositories, which are managed by NOAA-GFDL. We have a plan to replace these directories with git submodules or subtrees to the official repositories, which would help to keep our forks up to date, but would also lose any local changes to these sections.

Since these look like important changes, I would encourage you to also send these patches to the GFDL repositories while we work to integrate the MOM5 and FMS repos.

FMS:
https://github.com/NOAA-GFDL/FMS

FRE-NCtools:
https://github.com/NOAA-GFDL/FRE-NCtools

Thanks very much for the contribution!

@xiaobin1124
Copy link
Author

Looks good but I would change the declaration in fms_io.F90 to

integer(LONG_KIND) :: var_sz, size_in_file ! The size in bytes of each variable and of the variables already in a file.

for consistency (and portability).

@russfiedler Thanks for your suggestion, I just made the change and recommited.

@xiaobin1124
Copy link
Author

Hi @xiaobin1124, sorry for the long delay in replying to this. We've started to discuss how to improve governance of the code and how to keep track of these contributions.

The shared and tools directories are copies of the FMS and FRE tool repositories, which are managed by NOAA-GFDL. We have a plan to replace these directories with git submodules or subtrees to the official repositories, which would help to keep our forks up to date, but would also lose any local changes to these sections.

Since these look like important changes, I would encourage you to also send these patches to the GFDL repositories while we work to integrate the MOM5 and FMS repos.

FMS:
https://github.com/NOAA-GFDL/FMS

FRE-NCtools:
https://github.com/NOAA-GFDL/FRE-NCtools

Thanks very much for the contribution!

@marshallward Thanks for reminding me, I will check whether these patches are still needed in the FMS repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants