Basal fresh water flux support #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_tracer. code compiles with basal module
marshallward
changed the title
|
Hi Paul, I've renamed the issue to better describe the change, which looks a lot more significant than we had thought. We're trying to manage things a little better now, and start assigning these to people for merging. While I can't really comment on the science right now, I can suggest the following:
Also, it seems silly to keep the function in there while still commenting out the actual function call. There is probably a better way to control this, maybe with a namelist variable? I'll go over it some more and see if there's any other suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Just trying to make a branch for the basal melt flux code changes.
Cheers
P