Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Add Terser to Build Process #5

Merged
merged 6 commits into from
May 29, 2019
Merged

Add Terser to Build Process #5

merged 6 commits into from
May 29, 2019

Conversation

s0kil
Copy link
Contributor

@s0kil s0kil commented May 28, 2019

Adding Terser to optimize production build reduces size by 5x

@notrab
Copy link
Contributor

notrab commented May 28, 2019

This currently provides an issue in Safari, are you able to duplicate? The app won’t mount due to a duplicate binding I believe.

@s0kil
Copy link
Contributor Author

s0kil commented May 28, 2019

I'm not able to test on Safari, could you try the latest commit?

@s0kil
Copy link
Contributor Author

s0kil commented May 28, 2019

Another option is to add this package to NPM and use jsDelivr, which will minify the production files.

Something like this: https://cdn.jsdelivr.net/npm/@moltin/[email protected]/dist/index.min.js

@notrab notrab self-requested a review May 29, 2019 08:58
Copy link
Contributor

@notrab notrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with Safari!

@notrab notrab merged commit d64eab9 into moltin:master May 29, 2019
@github-actions
Copy link

github-actions bot commented Aug 3, 2020

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants