Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

feat: Add customers class #116

Merged
merged 6 commits into from
Sep 21, 2017
Merged

Conversation

thedrewid
Copy link
Contributor

@thedrewid thedrewid commented Sep 21, 2017

Status

  • ✅ Ready

Type

  • Feature

    Implements a new feature

Description

Adds CRUD functionality for Customers endpoints and implements unit testing

Dependencies

  • N/A

Issues

@ynnoj ynnoj changed the title Feat/add customer functionality to sdk feat: Add customers class Sep 21, 2017
@ynnoj ynnoj self-requested a review September 21, 2017 10:08

return Moltin.Customers.Get(1)
.then((response) => {
console.log(response)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thedrewid Remove please.

});
});

it('it should delete a customer', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thedrewid This test doesn't actually do anything. You aren't calling the Moltin.Customers.Delete() method and checking the response.

Drew Watson added 2 commits September 21, 2017 11:27
…ub.com/moltin/js-sdk into feat/add-customer-functionality-to-sdk

Commits made to branch that need to be pulled into local.
@ynnoj ynnoj merged commit 799607b into master Sep 21, 2017
@ynnoj ynnoj deleted the feat/add-customer-functionality-to-sdk branch September 21, 2017 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants