-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added spectypes #856
added spectypes #856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever approach! 👍🏼
Worried about adding the build steps. Not sure if this is far 😁
I decided to use additional build step here, because in future someone can create similar compiled validator library as a plugin for another compiler and this may result in a conflict when the same code will be processed by different compilers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work!
I'm not a friend of babel and codegen (the only 'codegen' that I like are Lisp macros 😁) as I've often been bitten by ultra complex build system setups.
But the performance and code-size is indeed hard to beat with plain functional approaches. And its safe too (you do the extra key checks and pass all strict tests). Also the generated code looks sufficiently readable.
Hi @hoeck ! Thanks for the feedback! |
Build failing |
|
oopsy, closed by accident |
Should be fixed now |
@iyegoroff impressive performance! A new record! 🥇 But what we did forget in this PR is the README mention, under "Packages Compared" heading. |
Hi @moltar!
Added spectypes
I have to update package-lock.json, because I was unable to access freajs.org for some reason.