Add dependency for mime-types v <3 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Rogier! Thanks for your Pull Request. |
|
Hi Rogier, I'm not really a ruby developer myself, so correct me if I'm wrong, but wouldn't it be better to fix this issue by adding support for the newer mime-types gem? |
|
Hi Daan, yes perhaps, but I think that should be solved within the REST Client gem. So to make sure your gem works, independently of REST Client, this might help. I am not sure whether this is a good solution though, it is more a 'quick fix'. |
Daanvm
approved these changes
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After installing the mollie-api-ruby gem I was not able to use the API, due to an "undefined method `[]' for #<Set: {#<MIME::Type: application/json>}>" error. I found out it was because of my version of mime-types (3.1).
This fix forces the use of mime-types < v3
See also: https://twitter.com/RogiervdBerg/status/768184731284414466
Version 2.99 of mime-types is still supported as 2.99.x, receiving quarterly updates of the IANA registry and security updates for two years. It will reach full end of life on 2017-11-21.