Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove resetCouponAfterCancellation because it's handled by CouponUsagesDecrement plugin #862

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanderjongsma
Copy link

I did not test it, but came across it, so this should be handled by magento in this plugin:

vendor/magento/module-sales-rule/etc/di.xml

<type name="Magento\Sales\Model\Service\OrderService">
        <plugin name="coupon_uses_decrement_plugin" type="Magento\SalesRule\Plugin\CouponUsagesDecrement" />
    </type>

It's probably not a big deal, but it can affect the coupon_usages number if it is applied twice.

Actually, the plugin has been in Magento for quite a while. I checked the merge request that added this functionality in Mollie, and it was from 2018. Magento later fixed it: GitHub Issue #12817. That's probably why it's still in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant