Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using Mocha contexts for variables #18

Closed
wants to merge 1 commit into from
Closed

Avoid using Mocha contexts for variables #18

wants to merge 1 commit into from

Conversation

jupiter
Copy link

@jupiter jupiter commented Apr 26, 2015

@moll
Copy link
Owner

moll commented Apr 26, 2015

Hey,

Thanks for the patch, though would you mind clarifying, why not use context properties? Wouldn't you say they're more suited for the job?

@jupiter
Copy link
Author

jupiter commented Apr 26, 2015

I just replied on the original thread here mochajs/mocha#1195 (comment), which hopefully makes sense.

@moll
Copy link
Owner

moll commented Apr 28, 2015

Would you feel terrible if I closed this pull request? Like we agreed in mochajs/mocha#1195 I too would prefer Mocha be fixed than work around it.

@jupiter
Copy link
Author

jupiter commented Apr 28, 2015

Not at all. Was really just an example.

@jupiter jupiter closed this Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jupiter @moll