Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript package versions used in the build should be reproducible #6461

Closed
fdlk opened this issue Jul 31, 2017 · 0 comments
Closed

Javascript package versions used in the build should be reproducible #6461

fdlk opened this issue Jul 31, 2017 · 0 comments
Assignees
@mark-de-haan
Labels
enhancement
Milestone
Sprint 109

Comments

@fdlk
Copy link
Contributor

fdlk commented Jul 31, 2017

How to Reproduce

See yarnpkg/yarn#570
If you don't provide a --pure-lockfile option during build, the lockfile may be updated when you run the build.

Expected behavior

Build should be reproducible.
So yarn Lockfile should be leading and build uses the versions specified in the lockfile.

Observed behavior

Build simply updates the lockfile if the versions do not match.
@mswertz mswertz added this to the Sprint 107 milestone Aug 14, 2017
@mswertz mswertz modified the milestones: Sprint 107, Sprint 108 Sep 1, 2017
mark-de-haan added a commit to mark-de-haan/molgenis that referenced this issue Sep 6, 2017
@mark-de-haan
Fix molgenis#6461 Javascript package versions used in the build shoul…
ced4448 
…d be reproducible
@LuukDijkhuis LuukDijkhuis modified the milestones: Sprint 108, Sprint 109 Sep 21, 2017
ConnorStroomberg added a commit to ConnorStroomberg/molgenis that referenced this issue Sep 29, 2017
@ConnorStroomberg
Fix molgenis#6461 Javascript package versions used in the build shoul…
e6d46d4 
…d be reproducible

WIP
Update yarn to release version 1.1
Update maven frontend plugin to 1.6 ( includes yarn fix)
Move configuration of frontend plugin version to central pom and use variable in sub-poms
@ConnorStroomberg ConnorStroomberg mentioned this issue Sep 29, 2017
Merged
8 tasks
ConnorStroomberg added a commit to ConnorStroomberg/molgenis that referenced this issue Sep 29, 2017
@ConnorStroomberg
Fix molgenis#6461 Javascript package versions used in the build shoul…
5ff5fb3 
…d be reproducible

Add frozen lock file option to yarn install to insure lock file does not get updated by accident
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-de-haan mark-de-haan

Labels
enhancement
Projects
None yet
Milestone
Sprint 109
Development

No branches or pull requests
4 participants
@mswertz @fdlk @mark-de-haan @LuukDijkhuis