-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reimplement rserve route #813
base: master
Are you sure you want to change the base?
Conversation
Sonar is failing, but coverage has been increased a lot. The added in code, is mostly old code that we're reintroducing. This code doesn't have many tests. Mostly because the complexity of tests that would have to be written, writing those tests would take up more time than having them would ever grant us. |
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Would like a quick chat for final acceptance.
Is it possible to reuse exact tests between Rock and Rserve using a parameter to run all test twice using either or? Maybe even a totally outside parameter via gradle. Or is this maybe we what I see.
I think the rock code lacks in the amount of tests it has. I have reintroduced the tests we had for rserve and added a couple new tests. I have tested both paths using our releasetest, using both profiles (rserve/rock) and that test succeeds both ways. |
how to test:
todo: