refactor: rock connection #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov is failing, but it's a refactor of existing code. Can't find where it should have more tests. |
mswertz
reviewed
Sep 8, 2024
| } | ||
| }; | ||
| private String getAuthHeader() { | ||
| String auth = application.getUser() + ":" + application.getPassword(); |
There was a problem hiding this comment.
This is such that a request from rock can use the password to authenticate so we know if the proces (that armadillo started via rock) has access to the data (from that user)?
Kinda scary, is there not a toke we could use instead? Or a way to at least encrypt this? Or is the internal communication also SSL? Because untrusted R code might now abuse it? Or to go even further, we could simply use a session number to reconnect because the password doesn't add much security?
mswertz
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the rock connection class, using the spring
RestClient, rather than the (deprecated)RestTemplate, as suggested by spring. This should prevent blocking calls and overall work more smoothly.Included apache in gradle, because default calls will go via jetty, which fails:
spring-projects/spring-boot#38960