-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add histoire/nuxt component lib using nuxt subproject #3386
Conversation
- add nuxt nuxt-components lib - add histoire to nuxt-components - setup tailwind - add workaround for tailwind relative path issue
…mx2 into feat/nuxt-components
I like this direction. We should discuss how we gonna do this considering the whole molgenis suite. Minor decisions such as will we start merging all components into this (I suppose this one is tailwind only?) or will we have different apps for different component libs? And do I understand correctly that nuxt will cherry pick the code to be included so we could combine two paradigms: having multiple apps/libs (current situation) as well as direct code sharing between the apps without needing the intermediate build step (potentially not needing that damned yarn workspaces anymore?) |
hmm i thought i had fixed that on local build by using your code from the histoire PR , i'm not that happy histoire config option , lots of little hacks to host it as part of emx2 , ill try to fix it |
yes its going to be hard to combine two css frameworks , if we decide to go with tailwind we maybe should consider moving the bootstrap components to tailwind ( nice job for llm :) )
yes , but i need to really check this in the prod build, but thats my understanding
when using vite as a dev server i suppose there no longer the need for multiple apps from a dev viewpoint, maybe there still is form a user viewpoint, but if you do ssr/really-good-tree-shaking that becomes more of a theoretical thing ( i.e browser should only load files need for current page/view). |
…mx2 into feat/nuxt-components
@@ -0,0 +1,7 @@ | |||
<template> | |||
<Story :layout="{ type: 'grid', width: '75%' }"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i really don't understand how changing the layout solved the base url issue ,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a bug in histoire, see histoire-dev/histoire#687
Quality Gate passedIssues Measures |
need to wait for histoire people to fix / update there release , maybe then look at again |
how to test:
todo: