Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp(index.d.ts): correct server type #340

Merged
merged 2 commits into from
Oct 22, 2023
Merged

imp(index.d.ts): correct server type #340

merged 2 commits into from
Oct 22, 2023

Conversation

0x0a0d
Copy link
Contributor

@0x0a0d 0x0a0d commented Oct 16, 2023

settings.server can be:

  • null/false/true: currently defined
  • net.Server if created by http.createServer or any class that extended
  • tls.Server if created by https.createServer, http2.createServer, http2.createSecureServer or any class that extended

icebob
icebob requested changes Oct 22, 2023
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve confict

@0x0a0d
Merge branch 'master' into d-ts-server
e303eee 
# Conflicts:
#	index.d.ts
@0x0a0d 0x0a0d requested a review from icebob October 22, 2023 16:26
icebob
icebob approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@icebob icebob merged commit f9b25ee into moleculerjs:master Oct 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x0a0d @icebob