Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: secure header assignment to avoid process crash #330

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: secure header assignment to avoid process crash #330

merged 1 commit into from
Sep 18, 2023

Conversation

furanzujin
Copy link
Contributor

@furanzujin furanzujin commented Aug 28, 2023 •
edited
Loading

Header assignments with invalid characters now don't lead to a gateway crash.

icebob
icebob requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but please revert the non-relevant changes (formatting, version upgrade, etc)

@furanzujin
Copy link
Contributor Author

Hello @icebob,
The requested changes have been applied.

@furanzujin furanzujin requested a review from icebob September 18, 2023 09:27
icebob
icebob approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@icebob icebob merged commit 29280b4 into moleculerjs:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response headers affectation
2 participants
@furanzujin @icebob