Merge pull request #337 from richardgarnier/richard/fix-stream-hang

Avoid stream hanging on error
moleculerjs · Oct 9, 2023 · c553ac5 · c553ac5
2 parents 4556386 + 211d116
commit c553ac5
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -19,6 +19,7 @@ const _ = require("lodash");
 const bodyParser = require("body-parser");
 const serveStatic = require("serve-static");
 const isReadableStream = require("isstream").isReadable;
+const { pipeline } = require('stream');
 
 const { MoleculerError, MoleculerServerError, ServiceNotFoundError } = require("moleculer").Errors;
 const { ServiceUnavailableError, NotFoundError, ForbiddenError, RateLimitExceeded, ERR_ORIGIN_NOT_ALLOWED } = require("./errors");
@@ -818,7 +819,11 @@ module.exports = {
 			} else {
 				// respond
 				if (isReadableStream(data)) { //Stream response
-					data.pipe(res);
+					pipeline(data, res, err => {
+						if (err) {
+							this.logger.warn("Stream got an error.", { err, url: req.url, actionName: action.name })
+						}
+					})
 				} else {
 					res.end(chunk);
 				}