Move unsync
and experimental dash
caches to a new crate called mini-moka
#200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks
unsync
cache deprecated and completely removes experimentaldash
cache frommoka
crate. They have been moved to a new crate calledmini-moka
.Reasons
dash
cachedash
cache was added tomoka
at v0.8.0.sync
cache.sync
cache had an issue Segmentation faults in moka-cht under heavy workloads on a many-core machine #34.dash
cache has a smaller but duplicate feature set tosync
cache.dash
cache inmoka
crate.dash
cash as it provides a smaller but enough feature set for their use cases.dash
cache, it would be nice if we move it to a new cratemini-moka
that will provide simpler and lighter cache implementations.unsync
cacheunsync
cache seems not popular and has a smaller feature set tosync
andfuture
cache.dash
cache tomini-moka
, it would make sense to moveunsync
cache tomini-moka
too.Why removing
dash
cache right now frommoka
while keepingunsync
cache as deprecated?dash
cache shares some base modules withsync
andfuture
caches.dash
provides different (smaller) feature set than others, it is becoming difficult to maintain the base modules.If
moka
user enablesdash
feature, it will fail to compile and show a message to introducemini-moka
crate.On the other hand,
unsync
cache shares very little part of the base modules with other caches.Also,
unsync
cache is always enabled, and there is no crate feature likedash
for it.mini-moka
crate if we completely remove it frommoka
.mini-moka
crate.unsync
cache later at v0.11.0.