Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date input conflicts #82

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Conversation

dalpo
Copy link
Contributor

@dalpo dalpo commented Mar 28, 2018

Starting from phoenix_html v2.11.0, this library define internally the date_input function which is causing a conflicts with local torch function:

== Compilation error in file lib/torch/views/filter_view.ex ==         
** (CompileError) lib/torch/views/filter_view.ex:176: imported Phoenix.HTML.Form.date_input/3 conflicts with local function                   
    (elixir) src/elixir_locals.erl:89: :elixir_locals."-ensure_no_import_conflict/3-lc$^0/1-0-"/2                                             
    (elixir) src/elixir_locals.erl:89: anonymous fn/3 in :elixir_locals.ensure_no_import_conflict/3                                           
    (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6                    
    (elixir) lib/kernel/parallel_compiler.ex:198: anonymous fn/4 in Kernel.ParallelCompiler.spawn_workers/6                                   
could not compile dependency :torch, "mix compile" failed. You can recompile this dependency with "mix deps.compile torch", update it with "mix deps.update torch" or clean it with "mix deps.clean torch"     

So, I renamed the private function Torch.FilterView.date_input into Torch.FilterView.torch_date_input.

This PR should resolve: #81

@dalpo dalpo changed the title Fix date input conflicts resolve #81 Fix date input conflicts Mar 28, 2018
@mrkaspa
Copy link

mrkaspa commented Apr 2, 2018

I have the same problem can we merge this?

@zberkom zberkom merged commit 1a8ddba into mojotech:master Apr 2, 2018
@dalpo dalpo deleted the fix-date-input-conflicts branch April 3, 2018 06:54
@dalpo
Copy link
Contributor Author

dalpo commented Apr 3, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mix torch.install - Phoenix.HTML.Form.date_input/3 conflicts with local function
3 participants