Add ability to set default sort order #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 19, 2017 20:43
Append sort params on pagination links only when explicitly given in `@conn.assigns`
danielberkompas
suggested changes
May 22, 2017
priv/templates/elixir/controller.ex
Outdated
| @@ -21,6 +21,11 @@ defmodule <%= module %>Controller do | |||
| @pagination_distance 5 | |||
|
|
|||
| def index(conn, params) do | |||
| params = Map.put_new(params, "sort_direction", "<%= sort_direction %>") | |||
| params = Map.put_new(params, "sort_field", "<%= sort_field %>") | |||
There was a problem hiding this comment.
This would be a good place to have a pipeline.
params =
params
|> Map.put_new("sort_direction", "<%= sort_direction %>")
|> Map.put_new("sort_field", "<%= sort_field %>")
added 2 commits
May 23, 2017 12:11
|
@danielberkompas I think d2baab9 addresses your feedback. Can you approve and merge? |
danielberkompas
approved these changes
May 30, 2017
|
@darin yep, sorry about the delay! Didn't mean to ignore this. |
|
@danielberkompas No worries - thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default sort order for a model in the admin can be set during generation. This is done by passing the sort field and sort direction as the last argument before the attributes when running
mix torch.gen.For example:
mix torch.gen eex Admin Post posts inserted_at desc title:string body:text inserted_at:dateFixes #32