add strictObject decoder #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewnoill
reviewed
Feb 18, 2021
| @@ -293,6 +293,43 @@ export class Decoder<A> { | |||
| }); | |||
| } | |||
|
|
|||
| static strictObject<A>(decoders?: DecoderObject<A>) { | |||
| const decoderKeys = isJsonObject(decoders) ? Object.keys(decoders) : []; | |||
There was a problem hiding this comment.
we don't need to decode decoders do we? Can just be
const decoderKeys = decoders ? Object.keys(decoders) : [];Can we make decoders a required field? Then it would be even simpler:
const decoderKeys = Object.keys(decoders);
chewnoill
reviewed
Feb 18, 2021
Comment on lines
+298
to
+305
| return new Decoder((json: unknown) => { | ||
| const invalidKeys = isJsonObject(json) | ||
| ? Object.keys(json).filter((key: string) => !decoderKeys.some((validKey: string) => key === validKey)) | ||
| : []; | ||
|
|
||
| if (invalidKeys.length > 0) { | ||
| return Result.err({message: `the following keys are present but not expected: ${invalidKeys.join(", ")}`}); | ||
| } |
There was a problem hiding this comment.
it might be better to represent this decoder as the intersection of the standard object decoder and another no extra keys decoder. Avoid copying the contents of that decoder into this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #57 and adds a
strictObjectdecoder. This decoder is much like theobjectdecoder, with the additional behavior of returning an error if the decoded object has extra keys that were not defined on the decoder.Fixes #57