Fixes #1140 for reports #1188
Open
Fixes #1140 for reports #1188
+136
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * <p>Include dependencies with version set in a parent or in a BOM.</p> | ||
| * <p>This is similar to {@code processDependencyManagementTransitive}, but will | ||
| * report updates on dependencies.</p> | ||
| * <p>Default is {@code false}.</p> |
There was a problem hiding this comment.
When we use defaultValue in @Parameter is will be added to docs.
By the way has different value .... doc and parameter
There was a problem hiding this comment.
I get your point, but I did not change processDependencyManagementTransitive in this PR.
On the other hand, this (initializing the properties) immensely helps with unit testing.
Added an integration test + showVersionless for dependency-updates-report
andrzejj0
force-pushed
the
dependency-report-issue-1140
branch
from
79e312c
to
2f41376
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to reproduce #1140 for reports, so here is a fix.
Added an integration test + showVersionless for dependency-updates-report.
Added some small refactoring.