Fixes #1182 and #1184: Bug fixes #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 16, 2024
…refactoring, fixed
andrzejj0
force-pushed
the
issue-1184
branch
from
9b1bf5c
to
b235939
Compare
slachiewicz
approved these changes
Nov 16, 2024
|
@slawekjaranowski please review |
slawekjaranowski
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1182, fixes a bug with segment determination for extensions when computing and displaying updates -- should be the same as for dependency updates -> extracted a helper method to handle both.
For #1184, it turns out Maven reports (both core and build) extensions as build plugins in the model, so we actually need to subtract extensions from build plugins.
Please review.