Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments in pom are moved by tidy:pom #3

Open
andham opened this issue Apr 19, 2016 · 4 comments
Open

comments in pom are moved by tidy:pom #3

andham opened this issue Apr 19, 2016 · 4 comments

Comments

@andham
Copy link
Member

andham commented Apr 19, 2016

tidy-m-p staged v1.0.0
Maven 3.3.3 on Oracle JDK 1.7.0_79 on Windows 7.

For some scenarios the pom mojomoves comments in the pom.

  1. Case 1

    <dependency>
        <!-- bla bla -->
        <groupId>org.apache.httpcomponents</groupId>
        <artifactId>httpclient</artifactId>
        <version>4.5.2</version>
    </dependency>
    

is changed to

    <dependency><!-- bla bla -->
        <groupId>org.apache.httpcomponents</groupId>
        <artifactId>httpclient</artifactId>
        <version>4.5.2</version>
    </dependency>
  1. Case 2:

    <dependency>
        <groupId>org.springframework.integration</groupId>
        <artifactId>spring-integration-java-dsl</artifactId>
        <version>1.1.2.RELEASE</version> <!-- TODO bla bla -->
    </dependency>
    

is changed to

    <dependency>
        <groupId>org.springframework.integration</groupId>
        <artifactId>spring-integration-java-dsl</artifactId>
        <version>1.1.2.RELEASE</version>
        <!-- TODO bla bla -->
    </dependency>
@andham andham added the bug label Apr 19, 2016
@jieryn
Copy link
Contributor

jieryn commented Apr 19, 2016

Comments at the end of line are kind of crummy to begin with...

@ymajoros
Copy link

@jieryn yeah, but that's what tidy plugin is doing itself, see case 1.

@jieryn
Copy link
Contributor

jieryn commented Jul 15, 2016

Sorry, I missed that. Thank you. Wonder why we're not even getting consistent behavior here, must be startXml vs endXml fragment handling.

@bmarwell
Copy link
Contributor

@jieryn @ymajoros @andham if you like to help, I started a branch with a check and a new comment tidy task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants