Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Update mojo-parent to 76, Maven 3.6.3, JDK 8 and GitHub Actions #138

Merged

Conversation

EagleErwin
Copy link
Contributor

This Pull Request updates the mojo-parent version to 76. Together with this, the Maven API is changed from 2.2.1 to 3.6.3 and the minimum Java version is changed from 6 to 8.

It also migrates from Travis CI to GitHub Actions CI.

PR #119 broke integration test rpm-dirmode. For now, I disabled this test. It should be enabled again when issues #118 and #125 are solved.

@slawekjaranowski
Copy link
Member

Cen we add GitHub actions in separate PR? - we will have status for next PR

@EagleErwin
Copy link
Contributor Author

EagleErwin commented Jul 19, 2023

Cen we add GitHub actions in separate PR? - we will have status for next PR

Do you mean just adding the .github/workflows/maven.yml file in a separate Pull Request (and maybe the changed badge in README.md)? It will make the build fail for sure if the other changes are not done, but I'm not sure if that is actually what you want.

.github/workflows/maven.yml Outdated Show resolved Hide resolved
.github/workflows/maven.yml Outdated Show resolved Hide resolved
.github/workflows/maven.yml Outdated Show resolved Hide resolved
.github/workflows/maven.yml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@slawekjaranowski
Copy link
Member

ok, we should merge whole PR at once ... please resolve my comments.

@slawekjaranowski slawekjaranowski changed the title Update mojo-parent to 76 Update mojo-parent to 76, Maven 3.6.3, JDK 8 and GitHub Actions Jul 19, 2023
@EagleErwin
Copy link
Contributor Author

Why have you changed from CentOS to Ubuntu?

I did it to match the build environment for Vagrant with the environment in GitHub CI. Would you prefer CentOS (9)?

@EagleErwin EagleErwin force-pushed the feature/update-mojo-parent branch 2 times, most recently from f69f84c to afa0d68 Compare July 21, 2023 11:01
@EagleErwin EagleErwin force-pushed the feature/update-mojo-parent branch from afa0d68 to aa20907 Compare July 21, 2023 11:31
@EagleErwin
Copy link
Contributor Author

I processed all review comments. I needed to do some minor changes in some tests in order to be run flawless on all Java / Maven version combinations, but now the builds are green.

@slawekjaranowski slawekjaranowski merged commit 62181aa into mojohaus:master Jul 21, 2023
@slawekjaranowski
Copy link
Member

@EagleErwin thanks - we have a green build.

@EagleErwin EagleErwin deleted the feature/update-mojo-parent branch July 21, 2023 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants